Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): use cultofcoders:mocha to support Meteor > 1.6.1 #52

Merged
merged 1 commit into from
May 15, 2018

Conversation

lmachens
Copy link
Contributor

Issue:
meteor test-packages ./ --driver-package practicalmeteor:mocha is failing for Meteor > 1.6.1 (see practicalmeteor/meteor-mocha#100).
Error:

I20180515-12:12:19.135(2)? Exception while invoking method 'mocha/runServerTests' Error: invalid reporter "[object Object]"
I20180515-12:12:19.136(2)?     at Mocha.reporter (C:\Users\lmachens\AppData\Local\.meteor\packages\practicalmeteor_mocha-core\1.0.1\npm\node_modules\mocha\lib\mocha.js:180:13)
I20180515-12:12:19.137(2)?     at MochaRunner.coffee.js.MochaRunner.runServerTests (packages/practicalmeteor_mocha/meteor/src/lib/MochaRunner.coffee:72:19)
I20180515-12:12:19.137(2)?     at MochaRunner.runServerTests (packages/practicalmeteor_mocha/meteor/src/lib/MochaRunner.coffee:1:1)
I20180515-12:12:19.139(2)?     at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1768:12)
I20180515-12:12:19.139(2)?     at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19)
I20180515-12:12:19.140(2)?     at Meteor.EnvironmentVariable.EVp.withValue (packages\meteor.js:1186:12)
I20180515-12:12:19.140(2)?     at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46)
I20180515-12:12:19.141(2)?     at Meteor.EnvironmentVariable.EVp.withValue (packages\meteor.js:1186:12)
I20180515-12:12:19.142(2)?     at Promise (packages/ddp-server/livedata_server.js:715:46)
I20180515-12:12:19.142(2)?     at new Promise (<anonymous>)
I20180515-12:12:19.143(2)?     at Session.method (packages/ddp-server/livedata_server.js:689:23)
I20180515-12:12:19.143(2)?     at packages/ddp-server/livedata_server.js:559:43

Solution:
cultofcoders:mocha works fine.

Other:
Tests are failing (should be fixed in other PR):
image

@paranoico paranoico merged commit bccbd08 into ccorcos:master May 15, 2018
@lmachens lmachens deleted the fix-1.6.1-tests branch May 15, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants