Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move to MQT Core package #290

Merged
merged 4 commits into from
Jul 8, 2023
Merged

🚚 Move to MQT Core package #290

merged 4 commits into from
Jul 8, 2023

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Jul 7, 2023

Description

This PR replaces the QFR submodule with the newly introduced MQT Core library that subsumes the QFR, DD package, and ZX package. At the moment, this entails no functional changes and only required minor adaptions.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code minor Part of a minor release labels Jul 7, 2023
@burgholzer burgholzer self-assigned this Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer
Copy link
Member Author

CirrusCI will always fail in PRs like these die to the way how it is configured (it's having problems with the repo rename when switching branches).
Assuming everything works as intended and merging whenever all other checks are green.

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #290 (ab9c5a7) into main (05f1424) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #290     +/-   ##
=======================================
+ Coverage   95.9%   96.1%   +0.1%     
=======================================
  Files         34      34             
  Lines       1721    1721             
  Branches     208     208             
=======================================
+ Hits        1652    1654      +2     
+ Misses        69      67      -2     
Flag Coverage Δ
cpp 95.7% <100.0%> (+0.1%) ⬆️
python 97.1% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Configuration.hpp 96.2% <ø> (ø)
include/checker/zx/ZXChecker.hpp 100.0% <ø> (ø)
src/EquivalenceCheckingManager.cpp 93.5% <ø> (ø)
src/checker/zx/ZXChecker.cpp 100.0% <ø> (ø)
include/EquivalenceCheckingManager.hpp 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 0a0249f into main Jul 8, 2023
31 of 33 checks passed
@burgholzer burgholzer deleted the mqt-core branch July 8, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file minor Part of a minor release submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant