Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👽 Update to latest mqt-core version #322

Merged
merged 13 commits into from
Nov 9, 2023
Merged

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Oct 30, 2023

Description

This PR adjusts QMAP to the latest interface changes in mqt-core.
In a follow-up PR, the newly introduced mqt.core Python package that include Python bindings for the QuantumComputation class will be introduced.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer
Copy link
Member

As for the Python build errors:
You can just remove anything related to #include "python/qiskit/QasmQobjExperiment.hpp".
It's no longer really supported (neither by Qiskit nor by us).

@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code enhancement Anything related to improvements of the existing library labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #322 (8b953fd) into main (3bca1f3) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #322   +/-   ##
=====================================
  Coverage   96.1%   96.1%           
=====================================
  Files         34      34           
  Lines       1738    1740    +2     
  Branches     212     212           
=====================================
+ Hits        1671    1673    +2     
  Misses        67      67           
Flag Coverage Δ
cpp 95.8% <100.0%> (+<0.1%) ⬆️
python 97.2% <ø> (ø)
Files Coverage Δ
include/checker/dd/simulation/StateGenerator.hpp 97.2% <ø> (ø)
src/EquivalenceCheckingManager.cpp 94.1% <100.0%> (+0.2%) ⬆️
...dd/applicationscheme/GateCostApplicationScheme.cpp 94.8% <100.0%> (ø)

... and 3 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer changed the title Added two-qubit zx tests and made qcec compatible to new core version. 👽 Update to latest mqt-core version Nov 9, 2023
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) November 9, 2023 15:59
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit aa57b2c into main Nov 9, 2023
32 checks passed
@burgholzer burgholzer deleted the zx-two-qubit-rotations branch November 9, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file enhancement Anything related to improvements of the existing library submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants