Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update scikit-build-core #328

Merged
merged 1 commit into from
Nov 9, 2023
Merged

⬆️ update scikit-build-core #328

merged 1 commit into from
Nov 9, 2023

Conversation

burgholzer
Copy link
Member

Description

This PR updates scikit-build-core to the latest version and drops the upper cap that was temporarily put in place.
Additionally, it simplifies the noxfile configuration a little bit to eliminate some redundancy and set lower bounds on the build time dependencies.
This ensures that a bump in the minimum required version of a build dependency will also be directly accounted for in nox sessions.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code packaging Anything related to Python packaging labels Nov 9, 2023
@burgholzer burgholzer self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #328 (0fa8d11) into main (aa57b2c) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #328     +/-   ##
=======================================
- Coverage   96.0%   95.9%   -0.1%     
=======================================
  Files         34      34             
  Lines       1740    1740             
  Branches     212     212             
=======================================
- Hits        1671    1670      -1     
- Misses        69      70      +1     
Flag Coverage Δ *Carryforward flag
cpp 95.6% <ø> (ø) Carriedforward from aa57b2c
python 97.2% <ø> (-0.3%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 68539e4 into main Nov 9, 2023
26 checks passed
@burgholzer burgholzer deleted the update-sbc branch November 9, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant