Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewdog demo - please delete #14

Closed
wants to merge 1 commit into from
Closed

Reviewdog demo - please delete #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -euo pipefail

function should_skip_image() {

Check warning on line 5 in build.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck 

[shellcheck] reported by reviewdog 🐶
The mentioned syntax error was in this function. [SC1009](https://github.com/koalaman/shellcheck/wiki/SC1009)

Raw Output:
./build.sh:5:1:info:The mentioned syntax error was in this function. [SC1009](https://github.com/koalaman/shellcheck/wiki/SC1009)

Check failure on line 5 in build.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck 

[shellcheck] reported by reviewdog 🐶
Couldn't parse this brace group. Fix to allow more checks. [SC1073](https://github.com/koalaman/shellcheck/wiki/SC1073)

Raw Output:
./build.sh:5:30:error:Couldn't parse this brace group. Fix to allow more checks. [SC1073](https://github.com/koalaman/shellcheck/wiki/SC1073)
local image_name="$1"
local skip_images=(${SKIP_IMAGES//,/ })
for skip_image in "${skip_images[@]}"; do
Expand All @@ -13,7 +13,6 @@
done
# echo "DEBUG: should_skip_image: Not skipping $image_name"
return 1 # one = false in Bash
}



Expand Down Expand Up @@ -206,3 +205,3 @@
echo
echo "========================"
exit 0
Loading