feat: schedule closing date #4433
Draft
+318
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://xmdnzu6er2w23acunbkcjfimne0bqktr.lambda-url.ca-central-1.on.aws/ |
timarney
reviewed
Oct 21, 2024
| const saveFormStatus = useCallback(async () => { | ||
| let closeDate = "open"; | ||
| let closeDate = "open"; // this wil reset the closing date to null; |
There was a problem hiding this comment.
We can pass just null vs "open" here and update the server action but we need to check of the closing date is already set in the future before we null out the date.
Originally I was passing open to avoid any potential JS type coercion with the API call --- which is now gone and replaced with a server action.
timarney
reviewed
Oct 21, 2024
| @@ -46,7 +46,17 @@ export const SetClosingDate = ({ | |||
| return true; | |||
| }, [closedMessage]); | |||
|
|
|||
| const [status, setStatus] = useState(closingDate ? "closed" : "open"); | |||
| // TODO: not working, needs more work | |||
| const isPastDate = useCallback( | |||
There was a problem hiding this comment.
Can use the dateHasPast util func here
const isPastClosingDate = dateHasPast(Date.parse(closingDate));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
TODO