Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update closing notice #4434

Merged
merged 2 commits into from
Oct 18, 2024
Merged

chore: Update closing notice #4434

merged 2 commits into from
Oct 18, 2024

Conversation

timarney
Copy link
Member

@timarney timarney commented Oct 18, 2024

Summary | Résumé

  • Adds closing notice to preview
  • Adds tests
  • Renames from Notice to ClosingNotice
Screenshot 2024-10-18 at 7 33 46 AM
  • 👉 Updates vitest config to allow test files to be co-located with the Component

Copy link
Contributor

add tests

add watch command
@@ -6,7 +6,7 @@ export default defineConfig({
test: {
globals: true, // migration from Jest - By default, vitest does not provide global APIs for explicitness
environment: "node",
// TODO: remove include after complete Vitest migration
include: ["__vitests__/**/*.test.ts", "lib/vitests/**/*.test.ts"],
// Note: The following pattern .vi.test.ts has been added to avoid conflicts with jest tests co-located with the source code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

thiessenp-cds
thiessenp-cds previously approved these changes Oct 18, 2024
Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@timarney timarney merged commit e5b2ff4 into main Oct 18, 2024
13 checks passed
@timarney timarney deleted the preview-closing-notice branch October 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants