Add base64 as an inlined implementation#402
Merged
santiagorodriguez96 merged 1 commit intocedarcode:masterfrom Oct 13, 2023
Merged
Add base64 as an inlined implementation#402santiagorodriguez96 merged 1 commit intocedarcode:masterfrom
santiagorodriguez96 merged 1 commit intocedarcode:masterfrom
Conversation
Contributor
|
Hey @olleolleolle! Thank you so much for your contribution! However, we were thinking about just inlining the implementation of Feel free making this adjustment in this PR (or create a new one). Otherwise I will try creating a new PR for the inlining change in the coming week 🙂 |
This avoids a warning emitted by Ruby 3.3.0-preview2. Fixes cedarcode#401.
476f8c6 to
e4e0c13
Compare
Contributor
Author
|
@santiagorodriguez96 Hope your weekend's good! |
santiagorodriguez96
approved these changes
Oct 13, 2023
Contributor
santiagorodriguez96
left a comment
There was a problem hiding this comment.
Thank you so much! ❤️
Have a nice weekend you too!
|
I think there's something missing here. The require in the file is still present, and |
Contributor
Author
| Indeed! In order to capture that where it can be seen, Issue #422. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a warning emitted by Ruby 3.3.0-preview2.
Fixes #401.
EDIT: inline the base64 implementation, and leave code comments that remind the reader about what they are seeing there.
Turn the base64 gem into a spec-supporting development dependency.