Feat operation param #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2024 09:12
Closes #22 The name of the operation must be specified in one the following ways: 1) .to("graph://get?...) 2) .to("graph://?operation=get") The parameter is case insensitive
marioscrock
reviewed
Sep 25, 2024
| @@ -44,8 +44,21 @@ protected void doStart() throws Exception { | |||
| } else { | |||
| operationConfig = new GraphBean(); | |||
| } | |||
|
|
|||
| // todo name of operation can either come from endpoint.getName() or endpoint.getOperationName() | |||
There was a problem hiding this comment.
@AuPath could you explain further the TODO?
marioscrock
reviewed
Sep 25, 2024
| String operation; | ||
| if (endpoint.getName().equals("") && endpoint.getOperation() != null) | ||
| operation = endpoint.getOperation(); | ||
| else if (endpoint.getName() != null && endpoint.getOperation() == null) |
There was a problem hiding this comment.
Check w.r.t. the same condition for inputFormat parameter in mapt component. What should be done if both are provided?
marioscrock
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the operation can now be specified in one the following ways:
.to("graph://get?...).to("graph://?operation=get")The parameter value is case insensitiveCloses #22