WPF/OffScreen - NullReferenceException in the WaitForRenderIdleAsync …

…method - Catch and throw exception back onto the calling thread so it doesn't crash the app Resovles #4902
cefsharp · Aug 21, 2024 · a7cc972 · a7cc972
1 parent 9b99752
commit a7cc972
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CefSharp.OffScreen/ChromiumWebBrowser.cs b/CefSharp.OffScreen/ChromiumWebBrowser.cs
@@ -762,6 +762,10 @@ public async Task WaitForRenderIdleAsync(int idleTimeInMs = 500, TimeSpan? timeo
                     // the same time, the timer maybe Disposed on a different thread.
                     // https://github.com/cefsharp/CefSharp/issues/4597
                 }
+                catch(Exception ex)
+                {
+                    renderIdleTcs.TrySetException(ex);
+                }
             };
 
             idleTimer.Start();

diff --git a/CefSharp.Wpf/ChromiumWebBrowser.cs b/CefSharp.Wpf/ChromiumWebBrowser.cs
@@ -2754,6 +2754,10 @@ public async Task WaitForRenderIdleAsync(int idleTimeInMs = 500, TimeSpan? timeo
                     // the same time, the timer maybe Disposed on a different thread.
                     // https://github.com/cefsharp/CefSharp/issues/4597
                 }
+                catch (Exception ex)
+                {
+                    renderIdleTcs.TrySetException(ex);
+                }
             };
 
             idleTimer.Start();