fixed WPF osr ime support #2103

starts2000 · 2017-07-31T07:58:50Z

fixed @ #1262

merceyz · 2017-08-25T15:49:26Z

Please write a more detailed description so it's easy to see what is done in this PR.

You seem to have changed things unrelated to IME support, please revert that.
Spaces not tabs (1 tab -> 4 spaces)
Use the same formatting style as the rest of the project

ashu3011 · 2017-09-15T21:40:51Z

Tried this fix on CefSharp.WPF.Example. There are 2 issue I encountered:
Issue1:
To recreate:

Run CefSharp.WPF.Example.
Keyboard Language should be set to any IME supporting language,
Type something in browser IME works fine,
Change tab
Type again

Result: IME doen't get displayed and you are typing in English

Issue 2

Null reference exception in chromiumwebbrowser.cs if the browser window is not displayed yet. The presentationsource returns null which causes the exception when you try to get handle while setting up _imewin

ashu3011 · 2017-09-19T01:13:35Z

For Issue 1: I don't get null reference exception any more but one of my browser is not properly initialized and thus I can not type in it.

Issue 2 still persists. In CefSharp.wpf example just open a new tab which will default to Google.com. Type a search query, IME will not appear.

cefsharp#2103 (comment)

ashu3011 · 2017-09-20T20:38:09Z

Works perfectly with Cef.WPF.Example . I am still having trouble with my xwt application but I think it has to do something with my implementation of it. The issue is that IME does not show up on initial load of the browser but works perfectly after I get away from it and come back to it. It persists to work rest of the time. I will look deeper and see if I can figure it out. Thanks.

ashu3011 · 2017-11-30T02:18:31Z

IME for Japanese language is not at the correct position, it appears at the bottom right of the screen. Also for other languages, IME do not correct position with Scale (Display settings on windows). Thus with few settings, depending on the monitors resolution, they appear on top of the input where IME is used and thus make it tough for users.

perlun

As others have pointed out, this PR needs a bit of cleanup before it's really reviewable. @starts2000, could you look into these details? Like, reverting the .csproj change, resolving the conflicts, using spaces instead of tabs etc.

Once that is done, I think we should give this a consideration. What does the rest of you think?

perlun · 2017-12-02T19:05:27Z

CefSharp.BrowserSubprocess/CefSharp.BrowserSubprocess.csproj

-  "$(DevEnvDir)..\..\VC\bin\amd64\editbin" /TSAWARE "$(TargetPath)"
-)</PostBuildEvent>
+    <PostBuildEvent>
+    </PostBuildEvent>


This part should be reverted, since it disables strong named signing.

perlun · 2017-12-02T19:05:43Z

CefSharp.Core/Internals/CefBrowserHostWrapper.cpp

@@ -1,4 +1,4 @@
-// Copyright � 2010-2017 The CefSharp Authors. All rights reserved.
+// Copyright ?2010-2017 The CefSharp Authors. All rights reserved.


This and other similar changes should be reverted - the copyright sign should remain in the previous encoding. (UTF-8 I presume)

amaitland · 2017-12-19T02:33:59Z

This PR conflicts with the changes proposed in #2056

AppVeyorBot · 2018-01-08T07:46:46Z

✅ Build CefSharp 63.0.0-CI2419 completed (commit c9a9698336 by @starts2000)

AppVeyorBot · 2018-01-17T01:58:21Z

✅ Build CefSharp 63.0.0-CI2434 completed (commit 5b38163c0c by @starts2000)

starts2000

ok

amaitland · 2018-01-18T06:34:22Z

#2056 has been merged. With those changes you should be able to implement your own IWpfKeyboardHandler and create a solution that requires no changes to the core CefSharp code. (You'll likely need to create a class that inherits from ChromiumWebBrowser).

Looking at the code it can be greatly simplified, there's lots of code there that has no relevance to CefSharp

amaitland

If we're going to add IME support then I think someone needs to investiage what options the WPF framework provides, I'm assuming TextBox and other input fields support IME, surely there's a cleaner approach than hacking some low level C++

amaitland · 2018-01-18T06:35:38Z

CefSharp.Core/Internals/CefBrowserHostWrapper.cpp

@@ -336,12 +336,30 @@ void CefBrowserHostWrapper::ImeSetComposition(String^ text, cli::array<Compositi
    _browserHost->ImeSetComposition(StringUtils::ToNative(text), underlinesVector, CefRange(), range);
 }

+void CefBrowserHostWrapper::ImeSetComposition(


These can likely be removed and you just get a reference to the underlying CefBrowserHost rather than adding code.

It's my understanding that some of the params are only used on Mac and can be left out of any Windows implementation.

amaitland · 2018-01-18T06:36:33Z

CefSharp.Wpf/ChromiumWebBrowser.cs

@@ -471,7 +496,7 @@ private void NoInliningConstructor()

            PresentationSource.AddSourceChangedHandler(this, PresentationSourceChangedHandler);

-            RenderOptions.SetBitmapScalingMode(this, BitmapScalingMode.HighQuality);
+            RenderOptions.SetBitmapScalingMode(this, BitmapScalingMode.NearestNeighbor);


Revert this, you can change it in your own code if you wish to adjust the quality.

amaitland · 2018-01-18T06:37:32Z

CefSharp.Wpf/ChromiumWebBrowser.cs

+
+                        if (CleanupElement != null)
+                        {
+                            Point point = this.TransformToAncestor(CleanupElement).Transform(new Point(0, 0));


Using CleanupElement here really isn't a reliably method to access the parent Window, which is what I'm assuming your doing. I'm sure you can find a better way of doing this.

amaitland · 2018-01-18T06:39:02Z

CefSharp.Wpf/ChromiumWebBrowser.cs

+
+                    if (source != null)
+                    {
+                        _imeWin = new OsrImeWin(source.Handle, this.browser);


If you create OsrImeWin when focus is gained and destroyed it when focus Is lost, is there a reason it's created here?

amaitland · 2018-01-18T06:39:31Z

CefSharp.Wpf/ChromiumWebBrowser.cs

@@ -1859,37 +1954,15 @@ protected virtual IntPtr SourceHook(IntPtr hWnd, int message, IntPtr wParam, Int
                return IntPtr.Zero;
            }

-            switch ((WM)message)
+            if (!IsDisposed && _imeWin != null && IsKeyboardFocused && browser != null)


You can now implement your own IWpfKeyboardHandler to capture and forward key events.

amaitland · 2018-01-18T06:41:28Z

CefSharp.Core/OsrImeHandler.h

+
+	// Handles IME for the native parent window that hosts an off-screen browser.
+	// This object is only accessed on the CEF UI thread.
+	class OsrImeHandler {


Unless there is a specific reason this is a separate class I think this should be merged into OsrImeWin

amaitland · 2018-01-18T06:41:41Z

CefSharp.Core/OsrImeHandler.h

+// governed by a BSD-style license that can be found in the LICENSE file.
+
+#ifndef CEF_TESTS_CEFCLIENT_BROWSER_OSR_IME_HANDLER_WIN_H_
+#define CEF_TESTS_CEFCLIENT_BROWSER_OSR_IME_HANDLER_WIN_H_


Remove this.

amaitland · 2018-12-07T03:38:11Z

Closing as I have no plans to merge this.

See #1262 (comment) for an alternative.

WPF osr IME support.

a0aa124

fixed cefsharp#2103 issue1 & issue2.

a0eb9b8

starts2000 added 2 commits September 19, 2017 12:09

update fixed

9cb1bb3

cefsharp#2103 (comment)

remove debug info.

8b9ae4f

perlun requested changes Dec 2, 2017

View reviewed changes

amaitland mentioned this pull request Dec 29, 2017

Prevent accelerator keys to work when typing text #2056

Merged

Merge branch 'master' into master

784f66b

Merge branch 'master' into master

931d232

starts2000 commented Jan 17, 2018

View reviewed changes

amaitland mentioned this pull request Jan 17, 2018

Funding Request - Release 63.0.0 #2234

Closed

26 tasks

amaitland requested changes Jan 18, 2018

View reviewed changes

amaitland mentioned this pull request Mar 6, 2018

WPF - IME Windows 8.1/10/11 #1262

Open

amaitland closed this Dec 7, 2018

amaitland added the not-ready-for-merge label Dec 7, 2018

Antonyo referenced this pull request in Antonyo/CefSharp Dec 9, 2018

Allow IME input in WPF through a managed keyboard handler.

f39c4bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed WPF osr ime support #2103

fixed WPF osr ime support #2103

starts2000 commented Jul 31, 2017

merceyz commented Aug 25, 2017

ashu3011 commented Sep 15, 2017

ashu3011 commented Sep 19, 2017 •

edited

Loading

ashu3011 commented Sep 20, 2017

ashu3011 commented Nov 30, 2017 •

edited

Loading

perlun left a comment

perlun Dec 2, 2017

perlun Dec 2, 2017

amaitland commented Dec 19, 2017

AppVeyorBot commented Jan 8, 2018

AppVeyorBot commented Jan 17, 2018

starts2000 left a comment

amaitland commented Jan 18, 2018

amaitland left a comment

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland Jan 18, 2018

amaitland commented Dec 7, 2018

		@@ -1,4 +1,4 @@
		// Copyright � 2010-2017 The CefSharp Authors. All rights reserved.
		// Copyright ?2010-2017 The CefSharp Authors. All rights reserved.

fixed WPF osr ime support #2103

fixed WPF osr ime support #2103

Conversation

starts2000 commented Jul 31, 2017

merceyz commented Aug 25, 2017

ashu3011 commented Sep 15, 2017

ashu3011 commented Sep 19, 2017 • edited Loading

ashu3011 commented Sep 20, 2017

ashu3011 commented Nov 30, 2017 • edited Loading

perlun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amaitland commented Dec 19, 2017

AppVeyorBot commented Jan 8, 2018

AppVeyorBot commented Jan 17, 2018

starts2000 left a comment

Choose a reason for hiding this comment

amaitland commented Jan 18, 2018

amaitland left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amaitland commented Dec 7, 2018

ashu3011 commented Sep 19, 2017 •

edited

Loading

ashu3011 commented Nov 30, 2017 •

edited

Loading