Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: avoid initializing schedules.crontab #687

Closed
wants to merge 3 commits into from

Conversation

k8scat
Copy link

@k8scat k8scat commented Oct 13, 2023

avoid initializing schedules.crontab while DJANGO_CELERY_BEAT_TZ_AWARE is True

Signed-off-by: K8sCat <k8scat@gmail.com>
@auvipy auvipy self-requested a review October 14, 2023 05:18
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have started the CI. is it possible to adjust/add some test for the change

@k8scat
Copy link
Author

k8scat commented Oct 17, 2023

I have started the CI. is it possible to adjust/add some test for the change

how can I add a test for CrontabSchedule model in this case

k8scat and others added 2 commits October 17, 2023 10:33
@k8scat k8scat closed this Oct 17, 2023
@k8scat k8scat reopened this Oct 17, 2023
@k8scat
Copy link
Author

k8scat commented Oct 17, 2023

I have started the CI. is it possible to adjust/add some test for the change

test added

@k8scat
Copy link
Author

k8scat commented Nov 3, 2023

I have started the CI. is it possible to adjust/add some test for the change

😸

@auvipy auvipy self-requested a review November 3, 2023 05:35
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to know more context about the change. why it is useful and if it breaks current apps

@k8scat k8scat closed this Nov 15, 2023
@auvipy
Copy link
Member

auvipy commented Nov 15, 2023

reason for closing please?

@k8scat
Copy link
Author

k8scat commented Nov 15, 2023

reason for closing please?

maybe not necessary

@auvipy
Copy link
Member

auvipy commented Nov 15, 2023

may I know why you feel that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants