Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements/test-djangoXY.txt #728

Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 7, 2024

Fixes #727

Concentrate testing state in just two files instead of lots of one-line files.

@cclauss cclauss force-pushed the streamline-requirements-test_django-files branch from 72d2e23 to b91018e Compare February 7, 2024 21:36
@cclauss cclauss changed the title Remove requirements//test-djangoXY.txt Remove requirements/test-djangoXY.txt Feb 7, 2024
@Nusnus Nusnus self-requested a review February 8, 2024 10:25
@Nusnus
Copy link
Member

Nusnus commented Feb 8, 2024

CleanShot 2024-02-08 at 19 08 38

LGTM - do you want also to maybe rename the job on the way? @cclauss

@cclauss
Copy link
Contributor Author

cclauss commented Feb 8, 2024

build is often used as a default job name in the GitHub Actions docs so I am OK with it.

If however, you want to suggest a different name, I have no objections.

@Nusnus Nusnus merged commit acd10a3 into celery:main Feb 8, 2024
17 checks passed
@cclauss cclauss deleted the streamline-requirements-test_django-files branch February 8, 2024 18:15
@cclauss
Copy link
Contributor Author

cclauss commented Feb 8, 2024

Thanks much as always!! I could use your help with getting a release published to PyPI (see Makefile).
Please see issue 680 for the history but I feel like this codebase is ready for a PyPI release that supports Dj5.0.

@Nusnus
Copy link
Member

Nusnus commented Feb 10, 2024

Thanks much as always!! I could use your help with getting a release published to PyPI (see Makefile).
Please see issue 680 for the history but I feel like this codebase is ready for a PyPI release that supports Dj5.0.

Let me see what I can do 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants