fix display of long name day of week #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
Apr 3, 2024
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
approved these changes
Apr 3, 2024
auvipy
approved these changes
May 4, 2024
|
Hi team, just noticed a potential issue with this change (edge case), created issue there #796 |
cclauss
reviewed
Aug 27, 2024
| ("mon", "Monday"), | ||
| ("Monday,tue", "Monday and Tuesday"), | ||
| ("sat-sun/2", "Saturday"), | ||
| ("mon-wed", "Monday, Tuesday, and Wednesday"), |
There was a problem hiding this comment.
I guess we were missing a good all_days_of_the_week test here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix display of long name for day of week at Admin panel.
issue: #647
previous workaround: 2798e36