Pre-commit: Add Python linter Ruff #778
Merged
+150
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
add-ruff-to-pre-commit
branch
from
e8c2e26
to
27b95b1
Compare
auvipy
requested changes
Jul 31, 2024
| @@ -24,8 +24,8 @@ class TaskSelectWidget(Select): | |||
|
|
|||
| def tasks_as_choices(self): | |||
| _ = self._modules | |||
| tasks = list(sorted(name for name in self.celery_app.tasks | |||
| if not name.startswith('celery.'))) | |||
| tasks = sorted(name for name in self.celery_app.tasks | |||
There was a problem hiding this comment.
I'm not fully sure about this change
There was a problem hiding this comment.
It is unnecessary to use list() around sorted(), as the latter already returns a list.
Running the following on the commandline...
unnecessary-call-around-sorted (C413)
Derived from the flake8-comprehensions linter.
Fix is always available.
What it does
Checks for unnecessary list or reversed calls around sorted
calls.
Why is this bad?
It is unnecessary to use list around sorted, as the latter already
returns a list.
[ ... ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff
A more gradual approach to: