Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #2052

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add support for Python 3.13 #2052

merged 1 commit into from
Oct 23, 2024

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Jul 5, 2024

Fixes #2051.

@rominf rominf marked this pull request as draft July 5, 2024 18:46
requirements/extras/confluentkafka.txt Outdated Show resolved Hide resolved
requirements/extras/zstd.txt Outdated Show resolved Hide resolved
@rominf rominf force-pushed the rominf-python3.13 branch 4 times, most recently from faefbe1 to d031fb7 Compare July 5, 2024 20:07
@Nusnus Nusnus self-requested a review July 6, 2024 00:37
@rominf rominf force-pushed the rominf-python3.13 branch 3 times, most recently from d26e891 to d14fa66 Compare July 12, 2024 06:48
@auvipy auvipy self-requested a review July 15, 2024 16:14
@auvipy
Copy link
Member

auvipy commented Jul 15, 2024

I fixed some merge conflicts, lets see how the integration test for python 3.13 works

@auvipy auvipy marked this pull request as ready for review September 22, 2024 13:26
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2052 (comment)

Should be resolved before merge

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR t/integration/test_kafka.py::test_KafkaBasicFunctionality::test_connect - NameError: name 'KafkaException' is not defined

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying some changes, let’s see how the CI reacts

requirements/extras/zstd.txt Outdated Show resolved Hide resolved
requirements/extras/confluentkafka.txt Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Nusnus Nusnus marked this pull request as draft September 22, 2024 13:48
@Nusnus
Copy link
Member

Nusnus commented Sep 22, 2024

@auvipy I’ve converted it back to Draft as the CI is not ready for merge at the moment.

@Nusnus
Copy link
Member

Nusnus commented Sep 22, 2024

@auvipy I’ve converted it back to Draft as the CI is not ready for merge at the moment.

I am also having issues with pytest-celery: celery/pytest-celery#420

Celery itself did pass the Python 3.13 CI though: celery/celery#9309

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (e5ea1f6) to head (a14bc3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2052   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files          77       77           
  Lines        9507     9507           
  Branches     1148     1148           
=======================================
  Hits         7747     7747           
  Misses       1569     1569           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rominf
Copy link
Contributor Author

rominf commented Oct 15, 2024

It looks like Google Cloud monitoring library (https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-monitoring) does not support Python 3.13:

TypeError: Couldn't build proto file into descriptor pool: duplicate symbol 'google.monitoring.v3.__firstlineno__'

See: https://github.com/celery/kombu/actions/runs/11343305734/job/31545591989?pr=2052#step:7:1141

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a feeling my last rebase would pass due to a recent dep update.

This is finally over, thanks everyone!

@Nusnus Nusnus marked this pull request as ready for review October 23, 2024 19:47
@Nusnus Nusnus merged commit c48be88 into celery:main Oct 23, 2024
42 checks passed
@rominf rominf deleted the rominf-python3.13 branch October 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
4 participants