-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): add PFM param #3864
Conversation
WalkthroughWalkthroughThe pull request introduces a new parameter, Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
specs/src/parameters_v2.md (1)
57-57
: LGTM! Consider adding a comma to improve readability.The addition of the new
packetfowardmiddleware.FeePercentage
parameter is well-documented and provides clarity on the fee structure for packet forwarding. Making it changeable via governance is a good decision for future flexibility.Consider adding a comma after "amount" to improve readability:
-| packetfowardmiddleware.FeePercentage | 0 | % of the forwarded packet amount which will be subtracted and distributed to the community pool. | True | +| packetfowardmiddleware.FeePercentage | 0 | % of the forwarded packet amount, which will be subtracted and distributed to the community pool. | True |Tools
LanguageTool
[uncategorized] ~57-~57: Possible missing comma found.
Context: ... | % of the forwarded packet amount which will be subtracted and distribute...(AI_HYDRA_LEO_MISSING_COMMA)
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- specs/src/parameters_v2.md (1 hunks)
Additional context used
LanguageTool
specs/src/parameters_v2.md
[uncategorized] ~57-~57: Possible missing comma found.
Context: ... | % of the forwarded packet amount which will be subtracted and distribute...(AI_HYDRA_LEO_MISSING_COMMA)
Closes #3862