fix: use same source of now #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
Jul 11, 2023
rach-id
approved these changes
Jul 11, 2023
cmwaters
added a commit
that referenced
this pull request
Jul 20, 2023
cmwaters
added a commit
that referenced
this pull request
Jul 24, 2023
cmwaters
added a commit
that referenced
this pull request
Jul 27, 2023
cmwaters
added a commit
that referenced
this pull request
Jul 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextStartTimeshould use the same source of time.Now() that is used to calculate how long to sleep before starting the next heightNote, I don't think this fixes the problem of the high block interval variance that we're seeing on mocha.