fix: end exclusive data commitment range fix #1058
Conversation
rach-id
changed the title
| @@ -335,8 +340,8 @@ func (indexer mockBlockIndexer) Search(ctx context.Context, _ *query.Query) ([]i | |||
|
|
|||
| // randomBlocks generates a set of random blocks up to the provided height. | |||
| func randomBlocks(height int64) []*types.Block { | |||
| blocks := make([]*types.Block, height) | |||
| for i := int64(0); i < height; i++ { | |||
| blocks := make([]*types.Block, height+1) | |||
There was a problem hiding this comment.
[note to reviewers]
Here, when we want to generate blocks up to a certain height, then we gonna have height+1 number of blocks because of genesis
There was a problem hiding this comment.
mind adding a bit more context to this change? for posterity, but also I'm missing some context here 😅 did we miss this before or accidentally change it to an incorrect range? can we do anything to make sure we are getting the correct range to ensure we don't do this in the future?
Yes, we changed the whole implementation to support exclusive end ranges, but we missed this change. And since we didn't run orchestrators with any version of the app that support exclusive end ranges, we didn't see it.
I added a test: https://github.com/SweeXordious/celestia-core/blob/5075e8d02d300af443aa214a198e88d51ab41f1c/rpc/core/blocks_test.go#L171-L175 |
Co-authored-by: Rootul P <rootulp@gmail.com>
|
Can we also get this merged to |
|
Definitly, ill open a PR shortly |
## Description Fixes celestiaorg/orchestrator-relayer#432 #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Rootul P <rootulp@gmail.com>
## Description Cherry pick #1058 to main #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- ## Description _Please add a description of the changes that this PR introduces and the files that are the most critical to review._ If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: Rootul P <rootulp@gmail.com>
Description
Fixes celestiaorg/orchestrator-relayer#432
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments