chore!: migrate to cometbft fork #1066
Conversation
cmwaters
requested review from
liamsi,
adlerjohn and
evan-forbes
as code owners
| // https://github.com/tendermint/tendermint/issues/1281 | ||
| // https://github.com/cometbft/cometbft/issues/1281 |
There was a problem hiding this comment.
fwiw I'm don't think its worth going through and finding each broken link as I don't think they're super useful and we can just manually fix the links adhoc if we really need to
| In particular, [tendermint/tendermint#6196](https://github.com/tendermint/tendermint/pull/6196) and previous changes that it depends on. | ||
| In particular, [tendermint/tendermint#6196](https://github.com/cometbft/cometbft/pull/6196) and previous changes that it depends on. |
There was a problem hiding this comment.
explicit links on the other hand (like http:// whatever) we might actually want to fix
that or disable the dead link linter
| @@ -1,4 +1,4 @@ | |||
| module github.com/tendermint/tendermint | |||
| module github.com/cometbft/cometbft | |||
There was a problem hiding this comment.
👍
When this PR lands in a release, we should call out in release notes that consumers of this library (i.e. celestia-app and celestia-node) need to change the replace statement in go.mod
| @@ -138,7 +138,7 @@ func (r *ReqRes) InvokeCallback() { | |||
| // marked done and SetCallback is called before calling GetCallback as that | |||
| // will invoke the callback twice and create a potential race condition. | |||
| // | |||
| // ref: https://github.com/tendermint/tendermint/issues/5439 | |||
| // ref: https://github.com/cometbft/cometbft/issues/5439 | |||
There was a problem hiding this comment.
[not blocking] Note this is now a broken link. I think we can fix the next time we pull upstream CometBFT code changes because CometBFT still uses the valid link.
|
Yeah I'm aware of the broken links and am aware that in doing this quickly I have probably created a few broken links. I don't think this is problematic because I don't think there is anyone using our fork as a reference of some information (other than the ADRs). I can use a link checker and go through and correct the places were I mistakenly changed the url in a different PR |
This ultimately changes the go.mod to using cometbft instead of tendermint which we will be using for the v0.37 release and is what the sdk depends on in v0.47