fix(types): Implement nil check on commit.ValidateBasic #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il commit will short-circuit without causing panic
cmwaters
approved these changes
Sep 25, 2023
|
Probably doesn't make too much sense because the checks are all prior to the |
|
It make sense to remove the call from there and keep it inside of ValidateBasic. Also, SignedHeader does the same check that could be moved. The main reason is to be consistent with other ValidateBasics that do the nil check internally |
evan-forbes
approved these changes
Sep 25, 2023
cmwaters
pushed a commit
that referenced
this pull request
Sep 28, 2023
Found in celestia-node header validation check. If a malformed `ExtendedHeader` with a nil Commit is broadcasted through the network, it would cause recipients to panic. We decided the check belongs in core as ValidatorSet also does a nil check.
evan-forbes
pushed a commit
that referenced
this pull request
Sep 28, 2023
Found in celestia-node header validation check. If a malformed `ExtendedHeader` with a nil Commit is broadcasted through the network, it would cause recipients to panic. We decided the check belongs in core as ValidatorSet also does a nil check.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in celestia-node header validation check. If a malformed
ExtendedHeaderwith a nil Commit is broadcasted through the network, it would cause recipients to panic. We decided the check belongs in core as ValidatorSet also does a nil check.