Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactors CAT mempool to use SendEnvelope instead of Send #1101

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore: refactors CAT mempool to use SendEnvelope instead of Send #1101

merged 2 commits into from
Sep 28, 2023

Conversation

staheri14
Copy link
Contributor

Closes #1099 and #1085

@staheri14 staheri14 self-assigned this Sep 27, 2023
@staheri14 staheri14 marked this pull request as ready for review September 28, 2023 00:10
cmwaters
cmwaters approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evan-forbes
evan-forbes approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@staheri14 staheri14 merged commit 79a1e14 into main Sep 28, 2023
14 checks passed
@staheri14 staheri14 deleted the sanaz/consolidate-sending-methods branch September 28, 2023 15:51
@staheri14 staheri14 mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters cmwaters approved these changes

Assignees

@staheri14 staheri14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance traffic observability by using SendEnvelope instead of Send
3 participants
@staheri14 @cmwaters @evan-forbes