Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds mempool v1 protocol spec #1108

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Oct 3, 2023

Part of #1080
This is the initial version of the mempool v1 protocol description, the content may undertake further updates (with new findings) in the follow up PRs.

@staheri14 staheri14 marked this pull request as ready for review October 3, 2023 23:14
@staheri14 staheri14 self-assigned this Oct 3, 2023
@staheri14 staheri14 requested a review from rootulp October 3, 2023 23:34
rootulp
rootulp previously approved these changes Oct 4, 2023
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
@staheri14 staheri14 requested a review from rootulp October 4, 2023 23:19
rootulp
rootulp previously approved these changes Oct 5, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Thanks for all the clarifications! Remaining suggestions are all markdownlint related but they could be addressed in the future if/when we enable markdownlint on this repo.

spec/p2p/reactors/mempool-v1.md Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
spec/p2p/reactors/mempool-v1.md Outdated Show resolved Hide resolved
@staheri14 staheri14 changed the title doc: adds mempool reactor doc doc: adds mempool v1 protocol spec Oct 6, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! great start and I can't wait to expand on this either directly via this document or via other reactors.

@staheri14 staheri14 merged commit 2144692 into main Oct 10, 2023
15 checks passed
@staheri14 staheri14 deleted the sanaz/mempool-v1-reactor-spec branch October 10, 2023 16:42
cmwaters pushed a commit that referenced this pull request Jul 30, 2024
Part of #1080
This is the initial version of the mempool v1 protocol description, the
content may undertake further updates (with new findings) in the follow
up PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants