-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: measures the max send rate and adds a test to ensure the max rate is observed #1112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when the flow rate is exceeded i.e. how is rate limiting of messages per peer conducted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
The expected data transmission rate is enforced by the implementation and should not exceed it. At a high level, the amount of data that can be sent every 100 ms (referred to as the sample rate) is calculated using a uniform distribution, specifically as |
Thanks for the context. So to summarise we block but don't drop the messages? |
Correct. |
Part of #1111