Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link to bug bounty #1496

Closed
wants to merge 13 commits into from

Conversation

guckool
Copy link

@guckool guckool commented Sep 21, 2024

Description

The link to the bug bounty mentioned in this readme is no longer valid, so I have updated it with the correct link which matches to the latest link mentioned in the cometbft spec: https://docs.cometbft.com/v0.38/spec/
image

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

No further tests is needed as only doc is modified

@guckool guckool requested a review from a team as a code owner September 21, 2024 20:30
@guckool guckool requested review from rach-id and evan-forbes and removed request for a team September 21, 2024 20:30
spec/README.md Outdated Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@rootulp
Copy link
Collaborator

rootulp commented Sep 23, 2024

IMO we should remove the entire spec/ directory from this fork rather than change one link.

@guckool
Copy link
Author

guckool commented Sep 23, 2024

IMO we should remove the entire spec/ directory from this fork rather than change one link.

Or should we remove the entire docs and leave only a readme in spec/ that points to the cometBFT spec repo?

@rootulp
Copy link
Collaborator

rootulp commented Sep 24, 2024

Or should we remove the entire docs and leave only a readme in spec/ that points to the cometBFT spec repo?

I think you mean entire specs and leave only a readme in spec/. That also works for me.

@guckool guckool closed this by deleting the head repository Sep 24, 2024
@guckool
Copy link
Author

guckool commented Sep 24, 2024

Hi @rootulp : sorry for that, to keep a clean history, I close this PR and combine those changes into one commit now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants