feat!: Add start time for continuous vesting accounts #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.46.x-celestia #342 +/- ##
============================================================
+ Coverage 65.54% 65.57% +0.03%
============================================================
Files 666 666
Lines 71161 71177 +16
============================================================
+ Hits 46644 46677 +33
+ Misses 21934 21916 -18
- Partials 2583 2584 +1
|
liamsi
commented
Aug 31, 2023
| return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().Bool(FlagDelayed, false, "Create a delayed vesting account if true") | ||
| cmd.Flags().Int64(FlagStartTime, 0, "Optional start time (as a UNIX epoch timestamp) for continuous vesting accounts. If 0 (default), the block's time of the block this tx is committed to will be used.") |
There was a problem hiding this comment.
Comment for reviewer:
It's a bit odd that end_time is passed as a mandatory arg but start-time as an optional flag:
create-vesting-account [to_address] [amount] [end_time] --start-time ...
liamsi
changed the title
evan-forbes
changed the title
liamsi
commented
Aug 31, 2023
evan-forbes
approved these changes
Aug 31, 2023
Comment on lines
+66
to
+80
| "create a continuous vesting account with start time": { | ||
| args: []string{ | ||
| sdk.AccAddress("addr2_______________").String(), | ||
| sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10))).String(), | ||
| "4070908800", | ||
| fmt.Sprintf("--%s=%d", cli.FlagStartTime, 4070808800), | ||
| fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address), | ||
| fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation), | ||
| fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync), | ||
| fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10))).String()), | ||
| }, | ||
| expectErr: false, | ||
| expectedCode: 0, | ||
| respType: &sdk.TxResponse{}, | ||
| }, |
There was a problem hiding this comment.
added a quick test here, but we're not checking that the state really functioned as intented
|
looking into this now: #342 (comment) |
rootulp
reviewed
Aug 31, 2023
x/auth/vesting/msg_server.go
Outdated
Comment on lines
55
to
59
| ctx = sdk.UnwrapSDKContext(goCtx) | ||
| if err := s.BankKeeper.IsSendEnabledCoins(ctx, msg.Amount...); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
[question] why is this check needed? It appears unrelated.
There was a problem hiding this comment.
Probably a rebase/merge glitch. This check is done much earlier in this function already!
d33df0b
evan-forbes
force-pushed
the
ismail-draft-vesting-start-time-2
branch
from
3176583
to
6729e1a
Compare
evan-forbes
approved these changes
Aug 31, 2023
liamsi
changed the title
evan-forbes
approved these changes
Aug 31, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes required for: #341
Note:
I had to regenerate proto files and was surprised that this changed a bunch generated code where the proto source wasn't modified 🤔fixedIdeally, the added command-line flag would also be tested in some fashion(see: 3176583 thanks @evan-forbes )Description
Closes: #341
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change