Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gentx Staker Space #364

Merged
merged 5 commits into from
Oct 24, 2023
Merged

add gentx Staker Space #364

merged 5 commits into from
Oct 24, 2023

Conversation

ilhanu
Copy link
Contributor

@ilhanu ilhanu commented Oct 21, 2023

For now just the gentx, the peer file will be updated later next week.

liamsi
liamsi reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase on the latest master or close reopen the same changes in a new PR? That would trigger CI to correctly fetch the most recent changes/fixes.

@liamsi
Copy link
Member

liamsi commented Oct 23, 2023

can you rebase one more time? the valid-gentx is green but it is not ran correctly due to: #398

liamsi
liamsi requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#364 (comment)

@liamsi liamsi self-requested a review October 23, 2023 19:29
liamsi
liamsi previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@liamsi
Copy link
Member

liamsi commented Oct 24, 2023 •
edited
Loading

Can you resolve the merge conflicts. I can't do it for you b/c you disabled that maintainers can edit PRs from your fork (which is fine btw).

@ilhanu ilhanu closed this Oct 24, 2023
@ilhanu ilhanu reopened this Oct 24, 2023
ilhanu
ilhanu commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to merge the latest changes in the fork before fixing the conflict.

liamsi
liamsi approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@liamsi liamsi enabled auto-merge October 24, 2023 10:15
@liamsi liamsi added this pull request to the merge queue Oct 24, 2023
Merged via the queue into celestiaorg:master with commit 9b43d51 Oct 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@YazzyYaz YazzyYaz YazzyYaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilhanu @liamsi @YazzyYaz