Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: genesis.json after gentx collection #505

Merged
merged 4 commits into from
Oct 27, 2023
Merged

chore: genesis.json after gentx collection #505

merged 4 commits into from
Oct 27, 2023

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Oct 26, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

evan-forbes
evan-forbes previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counted 75

@evan-forbes
Copy link
Member

evan-forbes commented Oct 26, 2023 •
edited
Loading

we should expect the run-network to fail. The validate genesis is failing because the file was modified which is also to be expected

@liamsi liamsi marked this pull request as ready for review October 27, 2023 10:17
@liamsi liamsi requested a review from YazzyYaz October 27, 2023 10:17
@liamsi
Copy link
Member Author

liamsi commented Oct 27, 2023

counted 75

same

@liamsi liamsi changed the title chore: pre-genesis.json after gentx collection chore: genesis.json after gentx collection Oct 27, 2023
@liamsi liamsi enabled auto-merge (squash) October 27, 2023 10:50
@liamsi liamsi merged commit 3b60f38 into master Oct 27, 2023
7 of 8 checks passed
@liamsi liamsi deleted the prep-genesis branch October 27, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bidon15 Bidon15 Bidon15 approved these changes

@YazzyYaz YazzyYaz YazzyYaz approved these changes

@evan-forbes evan-forbes evan-forbes left review comments

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamsi @evan-forbes @Bidon15 @YazzyYaz