fix(oauth2-core) 修复 tokenResponse 转换错误 (#195)

cellbang · Sep 23, 2023 · bd98f1e · bd98f1e
1 parent 6ca0f24
commit bd98f1e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change
 
+## 2.49.5
+
+- fix(oauth2-core) 修复 tokenResponse 转换错误
+
 ## 2.49.4
 
 - fix(cli) 移除 monorepo 中的 nx 依赖，降低对 node 版本的要求

diff --git a/packages/oauth2-core/src/node/endpoint/access-token-response-converter.ts b/packages/oauth2-core/src/node/endpoint/access-token-response-converter.ts
@@ -11,13 +11,17 @@ export class AccessTokenResponseConverter {
         const scopes = this.getScopes(tokenResponse);
         const refreshToken = tokenResponse[OAuth2ParameterNames.REFRESH_TOKEN];
 
+        const checkParameters = [
+            OAuth2ParameterNames.ACCESS_TOKEN,
+            OAuth2ParameterNames.EXPIRES_IN,
+            OAuth2ParameterNames.REFRESH_TOKEN,
+            OAuth2ParameterNames.SCOPE,
+            OAuth2ParameterNames.TOKEN_TYPE
+        ];
         const additionalParameters: { [key: string]: string } = {};
         for (const key in tokenResponse) {
-            if (Object.prototype.hasOwnProperty.call(tokenResponse, key)) {
-                if ([OAuth2ParameterNames.ACCESS_TOKEN, OAuth2ParameterNames.EXPIRES_IN,
-                    OAuth2ParameterNames.REFRESH_TOKEN, OAuth2ParameterNames.SCOPE, OAuth2ParameterNames.TOKEN_TYPE].indexOf(key) !== -1) {
-                    additionalParameters[key] = tokenResponse[key];
-                }
+            if (Object.prototype.hasOwnProperty.call(tokenResponse, key) && !checkParameters.includes(key)) {
+                additionalParameters[key] = tokenResponse[key];
             }
         }