Reorganise our code in preparation for our work on the interpreter #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, and algebraic variables.
…d algebraic variables for initialiseVariables().
…d algebraic variables for computeRates().
…d algebraic variables for computeVariables().
…d algebraic variables for computeComputedConstants().
To do it manually is very time consuming while here it gets done automatically. From there, we can quickly confirm, using git, whether the new expected file contents is correct.
…tants, and algebraic arrays.
… an equation. We will also need to keep track of states and constants.
…xternal variables.
…AIC_INFO, and EXTERNAL_INFO arrays rather than just the VARIABLE_INFO array.
…bles(). There was never a need to initialise them there in the first place. In fact, an external variable is effectively an algebraic variable which is computed by an end user. So, it needs to be computed in computeRates() (if available) and in computeVariables(). Also fixed an issue with initialiseVariables() not always including the VOI.
…ble. Even if the NLA equation only uses constant variables and constant values.
Constants are indexed using makeConstant().
agarny
force-pushed
the
issue1260
branch
5 times, most recently
from
be50526
to
9bf422f
Compare
agarny
force-pushed
the
issue1260
branch
3 times, most recently
from
28c2f4c
to
5d50f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260.