Fix static build and test on Linux. #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
FWIW, I thought that we would have needed to install zlib on Windows, but GHA's Windows runner seems to come with it since ZLIB_INCLUDE_DIR and ZLIB_LIBRARY are said to be not used. IOW, we might want anything related to zlib on GHA's Windows runner... in another issue?
nickerso
requested changes
Nov 10, 2024
nickerso
approved these changes
Nov 10, 2024
agarny
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #922.