Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Baklava migration block #2351

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Add Baklava migration block #2351

merged 2 commits into from
Feb 5, 2025

Conversation

palango
Copy link
Collaborator

@palango palango commented Feb 4, 2025

Description

Adds the Baklava migration block.

Resolves https://github.com/celo-org/celo-blockchain-planning/issues/884

@palango palango requested a review from gastonponti February 4, 2025 09:53
Copy link

github-actions bot commented Feb 4, 2025

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 6a9b47d

coverage: 55.3% of statements across all listed packages
coverage:  68.4% of statements in consensus/istanbul
coverage:  63.5% of statements in consensus/istanbul/announce
coverage:  57.5% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  66.2% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  52.4% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

Copy link

github-actions bot commented Feb 4, 2025

5889 passed, 1 failed, 45 skipped

Test failures:
  TestTransactionIndices: core

Failed
    blockchain_test.go:1946: Oldest indexded block mismatch, want 69, have 100
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just as a double check, this block with my numbers will be on Feb 20 2025 16:13:25 PM (+01:00 UTC)

@palango
Copy link
Collaborator Author

palango commented Feb 5, 2025

Yes, that's good.

@palango palango merged commit 6a9b47d into master Feb 5, 2025
27 checks passed
@palango palango deleted the palango/baklava branch February 5, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants