Increase MaxFrameLen to 16 MB #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EigenDA current limit for Holesky (their documentation is currently outdated but the limit seems to be set to 16 MB based on the updated tests from [this PR](Layr-Labs/eigenda-proxy#100)).
|
Tested on Holesky with EigenDA as AltDA. |
palango
reviewed
Sep 17, 2024
| // Data transactions that carry frames are generally not larger than 128 KB due to L1 network conditions, | ||
| // but we leave space to grow larger anyway (gas limit allows for more data). | ||
| const MaxFrameLen = 1_000_000 | ||
| // For AltDA, frames size can be larger. Setting to 16 MB as current blob limit for EigenDA. | ||
| const MaxFrameLen = 16_000_000 |
There was a problem hiding this comment.
How is the final size decided? Does that happen in the node or in the batcher?
There was a problem hiding this comment.
This change applies to derivation pipeline, and affects only to the limit enforced to op-node. op-batcher has a cmdflag to set the batch size limit (--max-l1-tx-size-bytes) and this is not affected by MaxFrameLen.
16 MB was chosen as it is currently the limit of blob size on EigenDA Holesky.
This does not mean that the frame size used is 16MB, but op-node would accept frames up to that size.
palango
approved these changes
Sep 18, 2024
carterqw2
pushed a commit
that referenced
this pull request
Sep 24, 2024
Updates DelayedWETH to use call instead of transfer because transfer only sends along 2300 gas which will cause the transfer to fail if the owner contract uses lots of gas in the fallback function. Adds tests that demonstrate that the function now works appropriately under any reasonable amount of gas usage. In theory this means the recovery function can be reentered but this isn't an issue because the function is authenticated and is recovering all of the ETH in the contract anyway.
jcortejoso
added a commit
that referenced
this pull request
Oct 18, 2024
On `celo10` branch I've observed in the batcher:
```
{"t":"2024-10-17T15:24:33.473665645Z","lvl":"crit","msg":"Application failed","message":"failed to setup: failed to init channel config: max frame size 999999 exceeds altDA max input size 130672"}
```
With previous `celo` versions this size limit was not enforced, and we increased the max frame size to 16MB in the derivation pipeline ([PR](#228)).
jcortejoso
added a commit
that referenced
this pull request
Nov 18, 2024
On `celo10` branch I've observed in the batcher:
```
{"t":"2024-10-17T15:24:33.473665645Z","lvl":"crit","msg":"Application failed","message":"failed to setup: failed to init channel config: max frame size 999999 exceeds altDA max input size 130672"}
```
With previous `celo` versions this size limit was not enforced, and we increased the max frame size to 16MB in the derivation pipeline ([PR](#228)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EigenDA current limit for Holesky (their documentation is currently outdated but the limit seems to be set to 16 MB based on the updated tests from this PR).