Merge pull request #174 from celonis/TA-2856-error-message-on-export

TA-2856: Reject from data on export packages error
celonis · Feb 14, 2024 · eb4d3fd · eb4d3fd
2 parents 1e643a9 + 45af8f4
commit eb4d3fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/services/http-client-service.v2.ts b/src/services/http-client-service.v2.ts
@@ -26,18 +26,20 @@ class HttpClientServiceV2 {
         return new Promise<any>((resolve, reject) => {
             axios.get(this.resolveUrl(url), {
                 headers: this.buildHeaders(contextService.getContext().profile),
-                responseType: "stream"
+                responseType: "stream",
+                validateStatus: status => status >= 200
             }).then(response => {
                 const data: Buffer[] = [];
                 response.data.on("data", (chunk: Buffer) => {
                     data.push(chunk);
                 });
                 response.data.on("end", () => {
-                    if (this.checkBadRequest(response.status)) {
-                        this.handleBadRequest(response.status, response.data, reject);
-                    } else {
-                        this.handleResponseStreamData(Buffer.concat(data), resolve, reject);
+                    if (response.status !== 200) {
+                        reject(Buffer.concat(data).toString());
+                        return;
                     }
+
+                    this.handleResponseStreamData(Buffer.concat(data), resolve, reject);
                 });
             }).catch(err => {
                 this.handleError(err, resolve, reject);

diff --git a/tests/utls/http-requests-mock.ts b/tests/utls/http-requests-mock.ts
@@ -17,6 +17,7 @@ const mockAxiosGet = (url: string, responseData: any) => {
                 readableStream.push(response.data)
                 readableStream.push(null);
                 return Promise.resolve({
+                    status: 200,
                     data: readableStream,
                 });
             } else {