Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA-2683] Setup tests and add tests for listing assignments #161

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

LaberionAjvazi
Copy link
Contributor

Description

Setup testing with jest and add tests for list assignments command.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

Copy link
Collaborator

@qmucolli qmucolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I'm wondering if we should think of adding SonarCloud and also handle a global test config which would do the initial generation of each test?

@LaberionAjvazi LaberionAjvazi marked this pull request as ready for review December 14, 2023 12:20
promeris
promeris previously approved these changes Dec 14, 2023
qmucolli
qmucolli previously approved these changes Dec 15, 2023
@promeris promeris changed the base branch from TA-2695-replace-request-module to master December 15, 2023 08:47
@promeris promeris dismissed stale reviews from qmucolli and themself December 15, 2023 08:47

The base branch was changed.

promeris
promeris previously approved these changes Dec 15, 2023
@promeris promeris merged commit c35bf3a into master Dec 15, 2023
@promeris promeris deleted the TA-2683-testing branch December 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants