Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA-3028: Update response transports for diff endpoints #185

Merged

Conversation

Buqeta
Copy link
Contributor

@Buqeta Buqeta commented Jun 3, 2024

Description

Updated the transports that are returned from diff endpoints with the following changes:

  • Diff package endpoint returns PackageDiffTransport which doesn't include the hasChanges property anymore.
  • Has changes endpoint now returns the PackageDiffMetadata which contains the packageKey and hasChanges properties.

Note: This PR should not be merged for now, because the backend changes haven't still been merged.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@Buqeta Buqeta requested review from GencBlakqoriP9 and a team as code owners June 3, 2024 15:54
@Buqeta Buqeta changed the title TA-3018: Update response transports for diff endpoints TA-3028: Update response transports for diff endpoints Jun 3, 2024
@Buqeta Buqeta requested review from ZgjimHaziri and promeris June 4, 2024 08:23
@Buqeta Buqeta merged commit 1fcb9fe into master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants