fixed issue 109: In memory grammar #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutersl
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to issue 109: #109 and also other related issues such as 104: #104.
The problem is with the in memory parser in which: (1) the function build_in_memory_grammar incorrectly initializes/writes the parser with lrk when the option is_rnglr is True. (2) the SDK incorrectly initializes the lexer as ContextFree when the option lexer_is_context_sensitive is True.
Therefore, the fix is to negate the conditions if the if conditions so that the lexer and the parser are created with the right kinds, e.g., LRK parser and ContextFree lexer.
A test case is attached for this bug fix.