Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix pr-check script always checking latest PR instead of current #38

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

gpmayorga
Copy link
Collaborator

Description

Due to a bug in one of the release scripts the version bump will always check the tags of the latest merged PR instead of the current PR when a PR is approved.

Fix included in PR #23 since I used it for testing

@gpmayorga gpmayorga mentioned this pull request Dec 20, 2024
@gpmayorga gpmayorga added the no-release Label to indicate not to release this PR label Dec 20, 2024
@gpmayorga gpmayorga enabled auto-merge (squash) December 20, 2024 20:21
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (80b0fca) to head (967afc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          24       24           
  Lines        3034     3034           
  Branches      275      275           
=======================================
  Hits         2708     2708           
  Misses        319      319           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gpmayorga gpmayorga merged commit a9f0527 into main Jan 3, 2025
6 of 7 checks passed
@gpmayorga gpmayorga deleted the ci-pr-check-fixes branch January 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Label to indicate not to release this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants