Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvmeof-gw: add cli commands to get/enable/disable SPDK logs #238

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

roysahar
Copy link
Contributor

This PR has coverage for this #20 (comment)

Signed-off-by: Roy Sahar <royswi@gmail.com>
@roysahar roysahar requested review from baum, barakda and caroav September 19, 2023 15:26
@caroav caroav requested a review from gbregman September 20, 2023 07:24
Signed-off-by: Roy Sahar <royswi@gmail.com>
Copy link
Contributor

@gbregman gbregman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🖖

Signed-off-by: Gil Bregman <134946773+gbregman@users.noreply.github.com>
@gbregman gbregman merged commit 10ab62d into ceph:devel Nov 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants