Don't call get_subsystems from within delete_bdev(). #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ceph#260 Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
Was originally PR #268 but it got closed by github |
oritwas
reviewed
Oct 19, 2023
oritwas
reviewed
Oct 19, 2023
oritwas
reviewed
Oct 19, 2023
oritwas
reviewed
Oct 19, 2023
oritwas
reviewed
Oct 19, 2023
Fixes ceph#260 Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
When we delete a bdev we go over any namespace which might use it and remove it. for this we used get_subsystems. Instead of using get_subsystem we now use the local state.