Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IPv6 parameters in NVMe CLI #298

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Handle IPv6 parameters in NVMe CLI #298

merged 1 commit into from
Oct 31, 2023

Conversation

gbregman
Copy link
Contributor

@gbregman gbregman commented Oct 30, 2023 •
edited
Loading

We got several issues with IPv6. first we need to allow the gateway to listen and accept connections using IPv6. Then we need to allow using IPv6 in different CLI parameters, like in the create_listener command.

Fixes #245
Fixes #247

Also fixes: bugzilla bug 2240580

@gbregman gbregman self-assigned this Oct 30, 2023
@gbregman gbregman requested a review from baum October 30, 2023 17:16
baum
baum reviewed Oct 31, 2023
View reviewed changes
control/cli.py Outdated Show resolved Hide resolved
@gbregman
Handle IPv6 parameters in NVMe CLI.
95af3bb 
Fixes ceph#245
Fixes ceph#247

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
@gbregman gbregman merged commit 792b9c0 into ceph:devel Oct 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baum baum baum approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When passing an IPv6 address as the gateway address we crash Fail to add a listener with IPv6
2 participants
@gbregman @baum