Merged
Conversation
cephalization
force-pushed
the
refactor-tests
branch
from
67135d5 to
a222935
Compare
cephalization
force-pushed
the
refactor-tests
branch
from
a222935 to
6c96843
Compare
- Added DexClient interface to dex.ts for dependency injection - Created defaultDexClient that wraps real dex CLI functions - Updated LoopOptions to accept optional dexClient parameter - Modified runLoop to use injected dexClient (defaults to real CLI) - Updated loop.test.ts mock.module to include defaultDexClient - All tests now passing (189 pass, 0 fail)
cephalization
force-pushed
the
refactor-tests
branch
from
6c96843 to
5ef3521
Compare
Addressed easy-to-fix flakiness patterns identified in audit: 1. migration.test.ts: - FIXED: Hardcoded TEST_DIR → now uses mkdtemp for unique temp directories - FIXED: Test isolation → each test gets isolated directory, no collision risk - Updated audit comments to reflect fixes 2. prune.test.ts: - FIXED: Hardcoded TEST_DIR → now uses mkdtempSync for unique temp directories - FIXED: Test isolation → each test gets isolated directory, no collision risk - Updated audit comments to reflect fixes 3. server.test.ts: - FIXED: WebSocket cleanup → added connection tracking and explicit cleanup - Added 100ms drain period in afterEach to ensure connections close properly - Updated audit comments to reflect fixes All tests still passing (189 pass, 0 fail). Remaining documented risks (process.chdir, timing dependencies) are acceptable and documented for future consideration.
Fixes TypeScript error TS2532 where readyTasks[0] could be undefined. Added explicit check for readyTasks[0] existence alongside length check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.