insert gpas-only logic into extID logic #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration of basic auth, gpas only logic, init check digit validation
check digit validation and 9 digit input, update configuration view
update UI for more user-friendly information provision
insert gpas-only logic into extID logic
cerhardt
requested changes
Sep 11, 2025
index.php
Outdated
| // redcap log | ||
| Logging::logEvent('', $module->getModuleName(), "OTHER", '', $sExtPS.": ".$sPSN, "extID: psn created"); | ||
|
|
||
| if ($module->getProjectSetting("save_sap_id") == true) { |
Owner
There was a problem hiding this comment.
würde ich so lassen wie es ist: "save_sap_id" ist nur als config Option in Kombination mit der Nutzung von SAP gedacht. Im "extpsn" Modus ist die ID ja nur zufällig eine SAP-ID und da greift die config-Option "extpsn_field", wenn man die ID in REDCap speichern möchte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate Pat.-ID is now fundamental for the logic that meets our requirements (the previous “basic auth” logic), i.e., entry of the 10-digit pat-id, processing with 9 digits in gpas, display as 10 digits in the record (if desired). Optionally, 9-digit input is still allowed – leading 0s are still not accepted.
This check takes place both in the
extpsn_labelsearch and in theextpsn_labelentry (in our case, the search acts as a preliminary check to see whether the pat-id is already stored in REDCap as a record - better said in gPAS. Only if this is not the case, a patient creation is suggested to be executed in the next step (the input from the search is transferred; the checks take place internally as usual).The functionalities from TestCases.md (Validate Pat.-ID (extID) Logic) are tested and work as expected.