-
Notifications
You must be signed in to change notification settings - Fork 166
[terra-search-field] Added invalid red box for invalid search field #3981
Conversation
&.error-clear { | ||
outline: var(--terra-search-field-focus-outline, 2px solid #e50000); | ||
outline-offset: var(--terra-search-field-focus-outline-offset, 1px); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need error outline on clear button. are these styles provided UX team ?
PR description is too vague Looking at the Jira 3973, Ask was to highlight the search field with red outline when user enters invalid value. In this case PR should only have changes on doc-site and not on source code. Since search field provides a callback prop example should update to pass required style changes to search field whenever they need. ( custom class names can be passed down through |
Why are we updating screenshots in this PR ..? As we can see PR has only doc example changes |
closing this PR changes will track under #3986 PR |
Summary
What was changed:
added invalid red box for invalid search field
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
closed : #3973
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra