This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-from-single-select] - Fixes screen reader issue #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Jan 2, 2024
| className={cx('visually-hidden-component')} | ||
| ref={this.visuallyHiddenComponent} | ||
| /> | ||
| {(!this.state.isSelect || this.state.isOpen) && <span aria-live={SharedUtil.isSafari() ? 'polite' : 'off'} className={cx('visually-hidden-component')} ref={this.visuallyHiddenComponent} />} |
There was a problem hiding this comment.
I think we need to check only for open state isOpen here. since instruction is read twice when drop-down is closed
sugan2416
reviewed
Jan 3, 2024
| @@ -287,6 +288,7 @@ class Frame extends React.Component { | |||
| this.setState({ | |||
| isOpen: false, | |||
| isAbove: false, | |||
| isSelect: true, | |||
There was a problem hiding this comment.
Unused var can be removed.
sugan2416
approved these changes
Jan 3, 2024
supreethmr
approved these changes
Jan 3, 2024
|
+1 The issue mentioned in the PR about the label getting announced twice and the expanded/collapsed state getting exposed twice is fixed for JAWS. It is getting exposed as expected. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we are getting few SR announcement issues. one is label announcing twice and second one is expanded combobox announcing twice and another one is selected label reading twice. With this PR we have fixed those SR issues.
What was changed:
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10100
Thank you for contributing to Terra.
@cerner/terra
Before fix :
After fix :
