This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-hyperlink] Fix focus indicator #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycombs
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Just checking, are the tests that were removed covered by the other existing tests?
There was a problem hiding this comment.
@sycombs - The tests that were removed were hard-coding the styles and not reflecting the true nature of the control. We do have WDIO tests to cover the focus indicators.
sycombs
approved these changes
Mar 28, 2024
adoroshk
approved these changes
Mar 29, 2024
|
@cm9361 - the visual focus indicator on clinical lowlight and terra default are working as required. |
@mjpalazzo - I think your approval is good enough in my opinion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The focus indicators for the default and lowlight theme were fixed for the Terra Hyperlink component.
Why it was changed:
The change was made to give consistency within the theme for the Hyperlink and Terra components that consume the control.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10326
Thank you for contributing to Terra.
@cerner/terra