Skip to content

Commit

Permalink
Drive-by fix of typo in the crds.keep value documentation
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Wall <richard.wall@venafi.com>
  • Loading branch information
wallrj committed Mar 1, 2024
1 parent 5eae98b commit 79f6408
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions deploy/charts/approver-policy/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion deploy/charts/approver-policy/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
},
"helm-values.crds.keep": {
"default": true,
"description": "This option makes it so that the \"helm.sh/resource-policy\": keep annotation is added to the CRD. This will prevent Helm from uninstalling the CRD when the Helm release is uninstalled. WARNING: when the CRDs are removed, all cert-manager custom resources\n(Certificates, Issuers, ...) will be removed too by the garbage collector.",
"description": "This option makes it so that the \"helm.sh/resource-policy\": keep annotation is added to the CRD. This will prevent Helm from uninstalling the CRD when the Helm release is uninstalled. WARNING: when the CRDs are removed, all cert-manager-approver-policy custom resources\n(CertificateRequestPolicy) will be removed too by the garbage collector.",
"type": "boolean"
},
"helm-values.dnsPolicy": {
Expand Down
4 changes: 2 additions & 2 deletions deploy/charts/approver-policy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ crds:
# This option makes it so that the "helm.sh/resource-policy": keep
# annotation is added to the CRD. This will prevent Helm from uninstalling
# the CRD when the Helm release is uninstalled.
# WARNING: when the CRDs are removed, all cert-manager custom resources
# (Certificates, Issuers, ...) will be removed too by the garbage collector.
# WARNING: when the CRDs are removed, all cert-manager-approver-policy custom resources
# (CertificateRequestPolicy) will be removed too by the garbage collector.
keep: true

# Number of replicas of approver-policy to run.
Expand Down

0 comments on commit 79f6408

Please sign in to comment.