Skip to content

Drop separate licenses check on master #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cert-manager-prow merged 1 commit into from
Jan 14, 2026
Merged

Drop separate licenses check on master #1103

cert-manager-prow merged 1 commit into from
Jan 14, 2026

Conversation

@inteon
Copy link
Member

@inteon inteon commented Jul 9, 2025

The licenses check is now included in the pull-cert-manager-master-make-verify check.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2025
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2025
@inteon inteon force-pushed the dont_check_licenses_separately branch from 7b22229 to 9fdf8f4 Compare September 14, 2025 08:48
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2025
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2025
@inteon
drop separate licenses check on master
11e5038 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the dont_check_licenses_separately branch from 9fdf8f4 to 11e5038 Compare January 14, 2026 16:06
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2026
@inteon
Copy link
Member Author

inteon commented Jan 14, 2026

/approve
/lgtm

@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 14, 2026

@inteon: you cannot LGTM your own PR.

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2026
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@cert-manager-prow cert-manager-prow bot merged commit e9cbf6d into master Jan 14, 2026
6 checks passed
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 14, 2026

@inteon: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
  • key cert-manager-release-1.19.yaml using file config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml
Details

In response to this:

The licenses check is now included in the pull-cert-manager-master-make-verify check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inteon