Add Certificate 'otherNames' SAN field description #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SpectralHiss
force-pushed
the
hef/add-othername-documentation
branch
from
de161cb to
33db262
Compare
73 tasks
wallrj
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @SpectralHiss
- Please branch from and merge this PR into release-next.
- Suggestion: Add a few more words to the release-notes-1.14.md page: https://github.com/cert-manager/website/blob/release-next/content/docs/releases/release-notes/release-notes-1.14.md#new-x509-features
- Suggestion: Give a concrete example of what this new feature allows you to do.
- Suggestion: Link to https://cert-manager.io/docs/installation/configuring-components/#feature-gates which explains how to enable the feature gate.
SpectralHiss
force-pushed
the
hef/add-othername-documentation
branch
from
33db262 to
3b04dfb
Compare
jetstack-bot
added
dco-signoff: no
jetstack-bot
added
size/S
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
SpectralHiss
force-pushed
the
hef/add-othername-documentation
branch
from
146cde3 to
6671232
Compare
jetstack-bot
added
dco-signoff: yes
* Explains the motivation behind the OtherName feature Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
jetstack-bot
added
size/S
added 2 commits
January 9, 2024 17:41
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
jetstack-bot
added
lgtm
wallrj
requested changes
Jan 10, 2024
jetstack-bot
removed
the
approved
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
|
@SpectralHiss I'll push a fix for that broken link and merge this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
This was referenced Jan 18, 2024
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a minimal level of documentation to the new otherNames field introduced in 1.14.0