Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-next] Also verify startupapicheck #1394

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[release-next] Also verify startupapicheck #1394

merged 1 commit into from
Jan 18, 2024

Conversation

SgtCoDFish
Copy link
Member

Blocked behind #1393

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 1724c5c
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65a945c31c03cf000827d734
😎 Deploy Preview https://deploy-preview-1394--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SgtCoDFish
add startupapicheck to signature verification commands
1724c5c 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@SgtCoDFish SgtCoDFish force-pushed the verify-startupapicheck branch from eb33138 to 1724c5c Compare January 18, 2024 15:37
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2024
@inteon
Copy link
Member

inteon commented Jan 18, 2024

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@jetstack-bot jetstack-bot merged commit 28bf739 into cert-manager:release-next Jan 18, 2024
4 checks passed
@SgtCoDFish SgtCoDFish deleted the verify-startupapicheck branch January 18, 2024 16:38
This was referenced Jan 19, 2024
Closed
Merged
@wallrj wallrj mentioned this pull request Jan 31, 2024
Closed
73 tasks
@jetstack-bot jetstack-bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtCoDFish @inteon @jetstack-bot